Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packages] Set metadata #6133

Merged
merged 3 commits into from
Feb 8, 2016
Merged

[packages] Set metadata #6133

merged 3 commits into from
Feb 8, 2016

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Feb 5, 2016

Sets vendor, license, maintainer, url, priority. Closes #6117.

➜  dpkg --info target/kibana_5.0.0-snapshot_amd64.deb 
...
 Package: kibana
 Version: 5.0.0-snapshot
 License: Apache 2.0
 Vendor: Elasticsearch, Inc.
 Architecture: amd64
 Maintainer: Kibana Team <info@elastic.co>
 Installed-Size: 124299
 Section: default
 Priority: optional
 Homepage: https://elastic.co
 Description: Explore and visualize your Elasticsearch data.

➜  rpm -qip target/kibana-5.0.0_snapshot-1.x86_64.rpm
Name        : kibana
Version     : 5.0.0_snapshot
Release     : 1
Architecture: x86_64
Install Date: (not installed)
Group       : default
Size        : 127281729
License     : Apache 2.0
Signature   : (none)
Source RPM  : kibana-5.0.0_snapshot-1.src.rpm
Build Date  : Fri 05 Feb 2016 12:48:03 PM CST
Build Host  : kibana-build
Relocations : / 
Packager    : Kibana Team <info@elastic.co>
Vendor      : Elasticsearch, Inc.
URL         : https://elastic.co
Summary     : Explore and visualize your Elasticsearch data.
Description :
Explore and visualize your Elasticsearch data.

@LeeDr
Copy link

LeeDr commented Feb 5, 2016

LGTM

1 similar comment
@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

LGTM

@epixa epixa assigned jbudz and unassigned LeeDr Feb 8, 2016
@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

Wait, I take back my LGTM.

The website should have www, which is consistent with both the elasticsearch package homepage and where we actually serve our site.

@jbudz
Copy link
Member Author

jbudz commented Feb 8, 2016

@epixa Nice catch, added www.

@jbudz jbudz assigned epixa and unassigned jbudz Feb 8, 2016
@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

LGTM

@epixa epixa assigned jbudz and unassigned epixa Feb 8, 2016
jbudz added a commit that referenced this pull request Feb 8, 2016
@jbudz
Merge pull request #6133 from jbudz/issues/6117
93b891b 
[packages] Set metadata
@jbudz jbudz merged commit 93b891b into elastic:master Feb 8, 2016
@elasticsearch-bot
Copy link

Jon Budzenski merged this into the following branches!

Branch Commits
4.x d951a87, 094c495, d821b5b
4.4 071c594, c392005, fc7a116

elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Add url, maintainer, vendor, license metadata
071c594 
Fixes #6133
elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Set deb-priority to optional
c392005 
Fixes #6133
elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Add www to metadata url
fc7a116 
Fixes #6133
elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Add url, maintainer, vendor, license metadata
d951a87 
Fixes #6133
elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Set deb-priority to optional
094c495 
Fixes #6133
elasticsearch-bot pushed a commit that referenced this pull request Feb 8, 2016
@jbudz
Add www to metadata url
d821b5b 
Fixes #6133
@epixa epixa added v4.4.2 and removed v4.4.1 labels Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbudz jbudz

Labels
review v4.4.2 v4.5.0 v5.0.0-alpha1 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @LeeDr @epixa @elasticsearch-bot